LG-5931 Document the rest of analytics events #13#6288
Merged
Conversation
stevegsa
force-pushed
the
stevegsa-doc-analytics-events
branch
from
2eed083 to
f5e8762
Compare
…bmitted, phone confirmation form, and vendor
zachmargolis
approved these changes
May 2, 2022
aduth
reviewed
May 4, 2022
| IDV_INTRO_VISIT = 'IdV: intro visited' | ||
| IDV_JURISDICTION_VISIT = 'IdV: jurisdiction visited' | ||
| IDV_JURISDICTION_FORM = 'IdV: jurisdiction form submitted' | ||
| IDV_PHONE_CONFIRMATION_FORM = 'IdV: phone confirmation form' |
Contributor
There was a problem hiding this comment.
Looks like this is still referenced on main here, causing a 500 for me locally:
I hit it after entering my password for a newly created account. Surprised that's not covered in a feature spec 🤔
Contributor
There was a problem hiding this comment.
Surprised that's not covered in a feature spec 🤔
Oh, it is 😬
But how did it pass here? 🤔 Edit: Ah, I think it was unfortunate merge timing with #6202, which added the reference to the constant.
peggles2
pushed a commit
that referenced
this pull request
May 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.